-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ring client pool in ruler to reduce number of gRPC connections created #3315
Comments
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
still valid |
still valid |
This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions. |
Done in #3916. |
Is your feature request related to a problem? Please describe.
When sharding is enabled, the ruler connects to all other rulers to retrieve all rules (see
Ruler.getShardedRules()
). To do it, we open a gRPC connection towards each ruler, each time thegetShardedRules()
is called. This leads to a bunch of new TCP connections created on a high traffic cluster.Describe the solution you'd like
Instead of opening a gRPC connection each time, we should use the ring's
client.NewPool()
to keep connections open and reuse clients.The text was updated successfully, but these errors were encountered: