Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ring client pool in ruler to reduce number of gRPC connections created #3315

Closed
pracucci opened this issue Oct 9, 2020 · 5 comments
Closed
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. stale

Comments

@pracucci
Copy link
Contributor

pracucci commented Oct 9, 2020

Is your feature request related to a problem? Please describe.
When sharding is enabled, the ruler connects to all other rulers to retrieve all rules (see Ruler.getShardedRules()). To do it, we open a gRPC connection towards each ruler, each time the getShardedRules() is called. This leads to a bunch of new TCP connections created on a high traffic cluster.

Describe the solution you'd like
Instead of opening a gRPC connection each time, we should use the ring's client.NewPool() to keep connections open and reuse clients.

@pracucci pracucci added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Oct 9, 2020
@stale
Copy link

stale bot commented Dec 8, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 8, 2020
@jtlisi
Copy link
Contributor

jtlisi commented Dec 8, 2020

still valid

@stale stale bot closed this as completed Dec 23, 2020
@jtlisi jtlisi removed the stale label Dec 24, 2020
@jtlisi jtlisi reopened this Dec 24, 2020
@jtlisi
Copy link
Contributor

jtlisi commented Dec 24, 2020

still valid

@stale
Copy link

stale bot commented Mar 26, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 26, 2021
@pracucci
Copy link
Contributor Author

Done in #3916.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. stale
Projects
None yet
Development

No branches or pull requests

2 participants