Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for DNS discovery for alertmanagers to find peers in a cluster #2883

Closed
samitpal opened this issue Jul 16, 2020 · 13 comments
Closed

Comments

@samitpal
Copy link
Contributor

It might be a good addition to add DNS discovery capability in multi-tenant alertmanager to discover peers. Right now there is a -cluster.peer flag which can be used multiple times but that has to be done statically. I tried with a dns host with multiple IP targets with -cluster.peer but it seems like the dns name does not get re-resolved when a host goes down.

@pracucci
Copy link
Contributor

Could you check if #2851 solve your issue, please?

I tried with a dns host with multiple IP targets with -cluster.peer but it seems like the dns name does not get re-resolved when a host goes down.

@gotjosh Are you aware of this?

@gotjosh
Copy link
Contributor

gotjosh commented Jul 20, 2020

I think this is slightly different but can use similar mechanisms. I've added the capability to discover Alertmanagers from the ruler, this is about discovering other Alertmanagers from the Alertmanager itself.

@gotjosh
Copy link
Contributor

gotjosh commented Jul 20, 2020

Could you please assign this to me @pracucci?

@pracucci
Copy link
Contributor

Could you please assign this to me @pracucci?

Definitely, done! 🙏

@stale
Copy link

stale bot commented Sep 18, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 18, 2020
@pracucci
Copy link
Contributor

Still valid

@stale stale bot removed the stale label Sep 18, 2020
@stale
Copy link

stale bot commented Nov 18, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 18, 2020
@pracucci
Copy link
Contributor

Still valid

@stale stale bot removed the stale label Nov 18, 2020
@stale
Copy link

stale bot commented Feb 16, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 16, 2021
@pracucci
Copy link
Contributor

Still valid

@stale stale bot removed the stale label Feb 17, 2021
@jtlisi jtlisi linked a pull request Feb 25, 2021 that will close this issue
3 tasks
@jtlisi jtlisi removed a link to a pull request Feb 25, 2021
3 tasks
@gotjosh
Copy link
Contributor

gotjosh commented Feb 25, 2021

Do we still want this? Moving forward, I'm not sure I see a point in improving the old clustering form.

@pracucci
Copy link
Contributor

Do we still want this? Moving forward, I'm not sure I see a point in improving the old clustering form.

I think the way ahead is the ring-based alertmanager scalability, which is what we're currently working on.

@jtlisi
Copy link
Contributor

jtlisi commented Mar 18, 2021

Closing this because we will be solving the use case of this issue using a ring-based scalable alertmanager

@jtlisi jtlisi closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants