Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use transferAndCall to reduce the investment in continuousFundraising to 1 transaction #131

Closed
CJentzsch opened this issue Mar 18, 2023 · 3 comments · Fixed by #222
Closed

use transferAndCall to reduce the investment in continuousFundraising to 1 transaction #131

CJentzsch opened this issue Mar 18, 2023 · 3 comments · Fixed by #222

Comments

@CJentzsch
Copy link
Collaborator

Currently, the investor has to make two transactions:

  • approve the amount in the currency contract
  • callbuy to execute the investment

When the token supports transferAndCall, the contracts could be changed to allow for an investment with 1 transaction.

ethereum/EIPs#677
@CJentzsch
Copy link
Collaborator Author

EUROC and USDC do not support EIP677, but EURe (Monerium) does.

@malteish
Copy link
Collaborator

Since EURe is our planned main payment token, extending ContinuousFundraising to be ERC677 compatible is the logical next step.

@malteish malteish mentioned this issue Nov 7, 2023
Merged
@malteish
Copy link
Collaborator

malteish commented Nov 9, 2023

done

@malteish malteish closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/transfer and call corpus-io/tokenize.it-smart-contracts
2 participants
@CJentzsch @malteish