Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unicons support and introduces CareIcons library for internal use #4071

Merged
merged 22 commits into from
Dec 3, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 18, 2022

Proposed Changes

How to use CareIcons

Care Icon's is a superset of Unicon's line icons. To use an Unicon line icon named "adjust" the following is the equivalent usage of CareIcon:

<CareIcon className="care-l-adjust text-lg text-primary-500" />

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 3, 2022 at 2:54PM (UTC)

@netlify
Copy link

netlify bot commented Nov 18, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3106dc0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/638b62d7096ec2000976fd57
😎 Deploy Preview https://deploy-preview-4071--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad changed the title `<CareIcon className="care-icon-name" /> <CareIcon className="care-icon-name" /> Nov 18, 2022
@rithviknishad rithviknishad changed the title <CareIcon className="care-icon-name" /> <CareIcon /> Nov 18, 2022
src/CAREUI/icons/icon.js Fixed Show fixed Hide fixed
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 18, 2022
src/CAREUI/icons/icon.js Fixed Show fixed Hide fixed
This was referenced Feb 28, 2023
@rithviknishad rithviknishad deleted the careui/icons branch July 26, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure needs review needs testing P1 breaking issue or vital feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use SVGs Instead of Unicons Improve how we consume icons in care
4 participants