-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated codec versions #507
feat: updated codec versions #507
Conversation
✅ Deploy Preview for cornerstone-wado-image-loader ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
So regarding the Charls decode in ms issue you mentioned in the cs3d. 50 iterations average I run the test for the old vs new Old:
New:
I guess it is not significantly worse. But the encode is significantly better |
hmmm that's really interesting that the decode is not slower... I'll try to benchmark and post a video of what I'm seeing (maybe it's a M2 issue?) I don't see any diffs when I use safari or mobile chrome fwiw |
cfed2a0
to
89fb2f4
Compare
@sedghi ready for review! |
Just to add to the comments above, we did rigorous testings and this PR does not add performance issues anymore |
🎉 This PR is included in version 4.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Updates codecs to current version.
Fixes this issue: #506