Make Embedded Class compatible with Pimcore 5.6 #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getDataForObject was returning empty arrays because the closure and the reflection class wasn't populate them in the EditmodeHelper class properties.
For Pimcore 5.6 the preGetData method was having a circular reference because the setter of the class was calling again the preGetData function.
|
|
|
FYI: Your PR is fine, tests fail cause Pimcore introduced a lot of BC breaks again |
|
thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Embedded Classes were not loading because some compatibility errors. Specifically, the
$typenamewas missing, a circular reference on the preGet method and theEditmodeHelperwasn't populating its attributes as expected.