Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Delayed messages are "missing" #2713

Open
NiklasBr opened this issue Sep 13, 2024 · 4 comments
Open

[Feature request] Delayed messages are "missing" #2713

NiklasBr opened this issue Sep 13, 2024 · 4 comments

Comments

@NiklasBr
Copy link
Contributor

Q A
Bug report? probably not
Feature request? probably yes
BC Break report? no
RFC? maybe

This issue lives in the gray area between a bug and a missing feature, so not sure how to answer with a clear yes-no above :) Leaning towards a feature request.

Dispatching a message like this with a delay to the availability will cause it to not show in the MessengerBundle interface leading to questions like "did it actually register in the system?"

Should they show? At least as a pending message, right? But maybe not as any other message with immediate availability? What do you think, what is a good way to solve it?

use App\Model\Messenger\ProductFetchMessage;
use Symfony\Component\Messenger\MessageBusInterface;
use Symfony\Component\Messenger\Stamp\DelayStamp;

class FooMessageHandler
{
    public function __construct(private MessageBusInterface $bus) {}

    public function someAction(): void
    {
        $this->bus->dispatch(
            new ProductFetchMessage($itemVariant->getId()),
            [new DelayStamp(86_400_000)]
        );
    }
}

Screenshot 2024-09-13 at 16 46 20

@dpfaffenbauer
Copy link
Member

@NiklasBr yes, I would count that as a missing feature

@jdreesen
Copy link
Contributor

I've noticed the same behavior with messages that have failed for some reason and are scheduled for a retry in the future. They are currently invisible, which is a little confusing.

@jdreesen
Copy link
Contributor

If it's a missing feature, will it only be added to 4.x (and thus in Pimcore 11)?

@dpfaffenbauer
Copy link
Member

something like this, we can still add to 3.2.x and merge up to 4.0.x and 4.1.x. Only bigger things is what we only do for new minor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants