Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payment Details can be null #1545

Closed
solverat opened this issue Dec 16, 2020 · 0 comments
Closed

Payment Details can be null #1545

solverat opened this issue Dec 16, 2020 · 0 comments
Labels
bug
Milestone
2.2.7

Comments

@solverat
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Because getPaymentSettings can be null, this will throw an exception:

CoreShop/src/CoreShop/Component/Order/Payment/OrderPaymentProvider.php

Line 74 in d92a978

$payment->setDetails(new ArrayObject($order->getPaymentSettings()));

image

This has been fixed on dev-master and is missing on 2.2:

CoreShop/src/CoreShop/Component/Order/Payment/OrderPaymentProvider.php

Line 58 in 1272a2b

$payment->setDetails(new ArrayObject($order->getPaymentSettings() ?? []));

@solverat solverat added the bug label Dec 16, 2020
@solverat solverat added this to the 2.2.6 milestone Dec 16, 2020
@dpfaffenbauer dpfaffenbauer modified the milestones: 2.2.6, 2.2.7 Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.2.7
Development

No branches or pull requests
2 participants
@solverat @dpfaffenbauer