embed: define "embed.CompactorMode*" #9247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Jan 29, 2018
embed/config.go
Outdated
| @@ -82,6 +83,11 @@ var ( | |||
| defaultHostStatus error | |||
| ) | |||
|
|
|||
| var ( | |||
| CompactorModePeriodic = compactor.ModePeriodic | |||
There was a problem hiding this comment.
can you comment on this public facing variable?
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
gyuho
force-pushed
the
internal-compactor
branch
from
15a9d9e
to
dc36b09
Compare
|
@xiang90 PTAL. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go internal packages cannot be imported by external projects. So, define compactor mode variable in embed packages. It broke https://travis-ci.org/coreos/etcdlabs/jobs/334931774#L467.