Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: deprecate 'golang.org/x/net/context' #8511

Merged
merged 5 commits into from
Sep 8, 2017
Merged

*: deprecate 'golang.org/x/net/context' #8511

merged 5 commits into from
Sep 8, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Sep 6, 2017

Address #6174.

Generated code still uses golang.org/x/net/context since golang/protobuf hasn't migrated yet. But we can still deprecate for rest of the code with Go 1.9 type alias in golang.org/x/net/context.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Use Go 1.9 type alias.

Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
@xiang90
Copy link
Contributor

xiang90 commented Sep 7, 2017

lgtm

@gyuho gyuho merged commit 6e39a39 into etcd-io:master Sep 8, 2017
@gyuho gyuho deleted the ctx branch September 8, 2017 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants