-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver, embed, integration: don't use pointer for ServerConfig #7909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks!
@xiang90 https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/services/etcd.go#L90 Tagging this in release note, as well. |
Codecov Report
@@ Coverage Diff @@
## master #7909 +/- ##
========================================
Coverage ? 75.9%
========================================
Files ? 332
Lines ? 26315
Branches ? 0
========================================
Hits ? 19974
Misses ? 4915
Partials ? 1426
Continue to review full report at Codecov.
|
@heyitsanthony Look good to me. One potential issue: |
44ca396
to
4301f49
Compare
@heyitsanthony shall we get this merged? |
ServerConfig is owned by etdcserver and unshared, so don't pass or store by pointer. Also removes duplicated field 'snapCount'.
ServerConfig is owned by etdcserver and unshared, so don't pass or store by
pointer. Also removes duplicated field 'snapCount'.