Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add bill of materials #7745

Merged
merged 2 commits into from
Apr 19, 2017
Merged

*: add bill of materials #7745

merged 2 commits into from
Apr 19, 2017

Conversation

heyitsanthony
Copy link
Contributor

This does not cover all the packages in etcd.

/cc @robszumski

Copy link
Contributor

@robszumski robszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

Copy link
Contributor

@robszumski robszumski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it seems to be not valid json:

Error: Parse error on line 202:
...dence": 0.953	}][	{		"project": "b
-------------------^
Expecting 'EOF', '}', ',', ']'

Missing comma?

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@heyitsanthony
Copy link
Contributor Author

@robszumski it doesn't like the second [] so I manually folded the error data into the first []

@gyuho
Copy link
Contributor

gyuho commented Apr 14, 2017

Do we have some script to generate this file? Or just comment here for future reference?

@heyitsanthony
Copy link
Contributor Author

@gyuho license-bill-of-materials github.com/coreos/etcd github.com/coreos/etcd/etcdctl

@xiang90
Copy link
Contributor

xiang90 commented Apr 15, 2017

lgtm

@codecov-io
Copy link

codecov-io commented Apr 15, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@0d52598). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7745   +/-   ##
=========================================
  Coverage          ?   76.02%           
=========================================
  Files             ?      331           
  Lines             ?    26058           
  Branches          ?        0           
=========================================
  Hits              ?    19811           
  Misses            ?     4825           
  Partials          ?     1422

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d52598...8a5f085. Read the comment docs.

@heyitsanthony
Copy link
Contributor Author

A few of these are still wrong (https://github.com/coreos-inc/coreos-pages/pull/1504). I can manually fix these but now it seems like the bom stuff won't be amenable to automation any time soon.
/cc @euank @xiang90

@heyitsanthony
Copy link
Contributor Author

updated broken detected license, revendored gopkg.in/yaml.v2 so it has the latest / more permissive license

@philips
Copy link
Contributor

philips commented Apr 17, 2017

These can be overridden using an override file: https://github.com/coreos/license-bill-of-materials#what-is-it

@heyitsanthony
Copy link
Contributor Author

@philips doesn't seem to work; it only hits error/no license cases and even then I'm not seeing it show up in the list. Including an override file anyway, though.

@heyitsanthony
Copy link
Contributor Author

Going to open an issue about automating this, but otherwise seems like if there's anything else that needs fixing it can be addressed in another PR. Merging.

@heyitsanthony heyitsanthony merged commit 85c9ea9 into etcd-io:master Apr 19, 2017
@heyitsanthony heyitsanthony deleted the bom branch April 19, 2017 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants