ctlv3: ensure synced member list before printing env vars on member add #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is kind of a hack. Member{Add,Update,Delete}Response should probably include the member list for the cluster so the commands are atomic. |
|
I am OK with this hack to solve the immediate problem. Returning the entire list for modification also seems OK. |
|
lgtm. shall we backport? |
In cases of multiple endpoints, it's possible member add would get a its member list from a member that has not yet recognized the membership update. Instead, confirm that the member list response is from the member that acked the member add or from a member that has synced with the cluster following the member add. Fixes etcd-io#7498
heyitsanthony
force-pushed
the
fix-etcdctl-add-member-env
branch
from
4957802
to
3e86779
Compare
Codecov Report
@@ Coverage Diff @@
## master #7499 +/- ##
=========================================
Coverage ? 70.09%
=========================================
Files ? 320
Lines ? 26184
Branches ? 0
=========================================
Hits ? 18354
Misses ? 6376
Partials ? 1454
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases of multiple endpoints, it's possible member add would get a its
member list from a member that has not yet recognized the membership
update. Instead, confirm that the member list response is from the
member that acked the member add or from a member that has synced
with the cluster following the member add.
Fixes #7498