clientv3: fix lease "freezing" on unhealthy cluster #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Dec 16, 2016
| mkReqs(1) | ||
| clus.Members[1].Stop(t) | ||
| mkReqs(2) | ||
| time.Sleep(time.Second) |
There was a problem hiding this comment.
otherwise the leader resumes too fast; couldn't trigger the failure without it
|
what was the original issue that this pr is trying to fix? |
|
|
lgtm probably worth to add the explanation #7023 (comment) to the commit message. |
Lack of GRPC code was causing this to look like a halting error to the client.
heyitsanthony
force-pushed
the
lease-freeze
branch
from
8eb54e1
to
9be9089
Compare
fanminshi
reviewed
Dec 16, 2016
| @@ -574,3 +576,54 @@ func TestLeaseKeepAliveLoopExit(t *testing.T) { | |||
| t.Fatalf("expected %T, got %v(%T)", clientv3.ErrKeepAliveHalted{}, err, err) | |||
| } | |||
| } | |||
|
|
|||
| func TestV3LeaseFailureOverlap(t *testing.T) { | |||
There was a problem hiding this comment.
It will be nice to add some explanation to why we need this test in the file. so the future reader might have a context.
Other than that LGTM.
added 2 commits
December 16, 2016 10:36
Was triggering cancelation errors on outstanding KeepAlives if Grant had to retry.
heyitsanthony
force-pushed
the
lease-freeze
branch
from
9be9089
to
a375e91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.