Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration: NewClusterV3() should launch cluster before creating clients #6222

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

hongchaodeng
Copy link
Contributor

What?
It changes NewClusterV3() to launch the cluster before creating clients.

Why?
Previously, NewClientV3() didn't have client connections established but kept retrying. If we have TLS handshake, it failed because it would block and return error.

@hongchaodeng
Copy link
Contributor Author

@timothysc
FYI, we need this to setup unit testing of secure v3 etcd connection in k8s to replace v2 testing infra.

@heyitsanthony
Copy link
Contributor

lgtm

@timothysc
Copy link

@hongchaodeng we'll need to rev the godeps again...

@xiang90
Copy link
Contributor

xiang90 commented Aug 18, 2016

@gyuho Can we cherry-pick this to 3.0 branch?

@gyuho
Copy link
Contributor

gyuho commented Aug 18, 2016

I am backporting this to release-3.0 branch, right after merge.

@xiang90 xiang90 merged commit 5e9fe0d into etcd-io:master Aug 18, 2016
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Aug 21, 2016
Automatic merge from submit-queue

godep: bump etcd to 3.0.6

What?
Bump etcd godep dependency to v3.0.6

Why?
ref: #30843, etcd-io/etcd#6222 
We have some fix to do secure client connection in unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants