v3rpc: don't elide next progress notification on progress notification #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heyitsanthony Great!!!! My double mistakes finally caused problem to myself... I failed to figure out why after quite a while investigation. |
|
lgtm |
a) 2 * progress interval was passing with dropped notifies b) waitResponse was waiting so long that it expected a dropped notify
heyitsanthony
force-pushed
the
fix-progress-notify
branch
from
85cfe36
to
8c8742f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5878
Clocked parts of the failing test, noticed the wait time was about 6s instead of 3s.