Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration: drain keepalives in TestLeaseKeepAliveCloseAfterDisconnectRevoke #5976

Merged
merged 1 commit into from
Jul 19, 2016
Merged

integration: drain keepalives in TestLeaseKeepAliveCloseAfterDisconnectRevoke #5976

merged 1 commit into from
Jul 19, 2016

Conversation

heyitsanthony
Copy link
Contributor

Fixes #5900

Way to repro: set the resend timer in sendKeepAliveLoop() to a millisecond and add a second delay after the stream.Recv() in recvKeepAliveLoop()

@xiang90
Copy link
Contributor

xiang90 commented Jul 18, 2016

lgtm

@heyitsanthony heyitsanthony merged commit fcc96c9 into etcd-io:master Jul 19, 2016
@heyitsanthony heyitsanthony deleted the fix-kadc branch July 19, 2016 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heyitsanthony @xiang90