Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI config arguments selectively override manifest metadata configuration #117

Open
bestdevever123 opened this issue Jan 20, 2025 · 1 comment
Labels
enhancement New feature or request triaged This issue was evaluated, no more information is needed

Comments

@bestdevever123
Copy link

Currently, when any configuration argument is passed via the CLI, the entire config of the manifest's metadata is ignored. This behavior is limiting and could be improved to allow CLI arguments to override only the specific equivalent configurations in the manifest while keeping the rest intact.

Proposed Solution

Change the behavior so that CLI configuration arguments only override their corresponding configurations in the manifest's metadata. The rest of the configurations from the manifest should remain in effect unless explicitly overridden by CLI arguments.

Rationale

Selective Overrides: This approach allows users to benefit from default configurations in the manifest without needing to duplicate them in CLI arguments.

Practical Example:

Consider a scenario where the manifest contains a very long exclude-crate-paths configuration.
If I want to override only the platform configuration via the CLI, I am forced to re-specify the entire exclude-crate-paths value as a CLI argument, which is sub optimal.

With the proposed change, I could override the platform while leaving exclude-crate-paths and other configurations untouched.

Thx for your work!

@cgwalters cgwalters added enhancement New feature or request triaged This issue was evaluated, no more information is needed labels Jan 20, 2025
@cgwalters
Copy link
Member

Change the behavior so that CLI configuration arguments only override their corresponding configurations in the manifest's metadata. The rest of the configurations from the manifest should remain in effect unless explicitly overridden by CLI arguments.

I'm OK with this, I think it's a relatively safe change to make by default. I wonder if we should add a --no-inherit-manifest or something to opt in to the previous behavior in case? Dunno if it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged This issue was evaluated, no more information is needed
Projects
None yet
Development

No branches or pull requests

2 participants