From 9efb7d33b719285a3a033154329af9f927b35e44 Mon Sep 17 00:00:00 2001 From: Christopher Friedt Date: Tue, 30 Jan 2024 23:58:30 -0500 Subject: [PATCH] posix: remove unneeded option to link with posix subsys The CONFIG_APP_LINK_WITH_POSIX_SUBSYS option was originally present so that internal POSIX implementation headers would be on the include path. There is no implicit need for any app or library to include private POSIX headers. Instead, the standard POSIX API should be used. (cherry picked from commit e8b178411c7ede4279da03aa2c6d0402811480bd) Original-Signed-off-by: Christopher Friedt GitOrigin-RevId: e8b178411c7ede4279da03aa2c6d0402811480bd Change-Id: Ife0226851093a58bd73bfa39b8798311f6a4b8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5280060 Reviewed-by: Al Semjonovs Tested-by: Al Semjonovs Commit-Queue: Al Semjonovs Tested-by: ChromeOS Prod (Robot) --- doc/services/portability/posix/kconfig/index.rst | 1 - lib/posix/options/CMakeLists.txt | 5 ----- lib/posix/options/Kconfig | 9 --------- 3 files changed, 15 deletions(-) diff --git a/doc/services/portability/posix/kconfig/index.rst b/doc/services/portability/posix/kconfig/index.rst index c1599dd5506..0ce0e5bb4b4 100644 --- a/doc/services/portability/posix/kconfig/index.rst +++ b/doc/services/portability/posix/kconfig/index.rst @@ -6,7 +6,6 @@ Configuration Options This is a non-exhaustive list of specific :ref:`kconfig` options relating to Zephyr's implementation of the POSIX API. -* :kconfig:option:`CONFIG_APP_LINK_WITH_POSIX_SUBSYS` * :kconfig:option:`CONFIG_EVENTFD` * :kconfig:option:`CONFIG_EVENTFD_MAX` * :kconfig:option:`CONFIG_FDTABLE` diff --git a/lib/posix/options/CMakeLists.txt b/lib/posix/options/CMakeLists.txt index b523e859e86..a0c1722df6a 100644 --- a/lib/posix/options/CMakeLists.txt +++ b/lib/posix/options/CMakeLists.txt @@ -6,8 +6,6 @@ zephyr_syscall_header( posix_clock.h ) -zephyr_interface_library_named(posix_subsys) - if(CONFIG_POSIX_API) zephyr_include_directories(${ZEPHYR_BASE}/include/zephyr/posix) endif() @@ -63,6 +61,3 @@ zephyr_library_include_directories( ${ZEPHYR_BASE}/kernel/include ${ARCH_DIR}/${ARCH}/include ) - -zephyr_library_link_libraries(posix_subsys) -zephyr_library_property(ALLOW_EMPTY TRUE) diff --git a/lib/posix/options/Kconfig b/lib/posix/options/Kconfig index 9b738c9bdba..c2673e164dd 100644 --- a/lib/posix/options/Kconfig +++ b/lib/posix/options/Kconfig @@ -12,15 +12,6 @@ config POSIX_API Enable mostly-standards-compliant implementations of various POSIX (IEEE 1003.1) APIs. -# The name of this option is mandated by zephyr_interface_library_named -# cmake directive. -config APP_LINK_WITH_POSIX_SUBSYS - bool "Make POSIX headers available to application" - default y - depends on POSIX_API - help - Add POSIX subsystem header files to the 'app' include path. - if POSIX_CLOCK config PTHREAD_IPC