Skip to content

Commit

Permalink
chore: add helm lint to otel solutions
Browse files Browse the repository at this point in the history
  • Loading branch information
povilasv committed Oct 10, 2023
1 parent 46fe918 commit c75afd0
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/otel-agent-helm-test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Otel Agent Helm Install Test
name: Otel Agent Helm Lint and Install Test

on:
pull_request:
Expand All @@ -18,5 +18,5 @@ jobs:
with:
create-kind-cluster: "true"
- name: Run chart-testing (install)
run: ct install --charts otel-agent/k8s-helm
run: ct lint-and-install --charts otel-agent/k8s-helm

4 changes: 2 additions & 2 deletions .github/workflows/otel-infra-helm-test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Otel Infrastructure Collector Helm Install Test
name: Otel Infrastructure Collector Helm Lint and Install Test

on:
pull_request:
Expand All @@ -20,5 +20,5 @@ jobs:
- name: Setup Secret
run: kubectl create secret generic coralogix-keys --from-literal=PRIVATE_KEY=123
- name: Run chart-testing (install)
run: ct install --namespace default --charts otel-infrastructure-collector/k8s-helm
run: ct lint-and-install --namespace default --charts otel-infrastructure-collector/k8s-helm

4 changes: 2 additions & 2 deletions .github/workflows/otel-integration-helm-test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Otel Integration Helm Install Test
name: Otel Integration Helm Lint And Install Test

on:
pull_request:
Expand All @@ -20,4 +20,4 @@ jobs:
- name: Setup Secret
run: kubectl create secret generic coralogix-keys --from-literal=PRIVATE_KEY=123
- name: Run chart-testing (install)
run: ct install --namespace default --charts otel-integration/k8s-helm
run: ct lint-and-install --namespace default --charts otel-integration/k8s-helm
2 changes: 1 addition & 1 deletion otel-infrastructure-collector/k8s-helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ opentelemetry-collector:
application_name: "{{.Values.global.defaultApplicationName }}"
subsystem_name: "{{.Values.global.defaultSubsystemName }}"
processors:
memory_limiter: null # Will get the k8s resource limits
memory_limiter: null # Will get the k8s resource limits

Check failure on line 90 in otel-infrastructure-collector/k8s-helm/values.yaml

View workflow job for this annotation

GitHub Actions / collector-test

90:28 [comments] too few spaces before comment
transform/kube-events:
log_statements:
- context: log
Expand Down

0 comments on commit c75afd0

Please sign in to comment.