Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with backpack usernames showing up for send list and send view #3645

Closed
trucy opened this issue Apr 8, 2023 · 2 comments · Fixed by #3646
Closed

Regression with backpack usernames showing up for send list and send view #3645

trucy opened this issue Apr 8, 2023 · 2 comments · Fixed by #3646
Assignees
Labels
bug Something isn't working

Comments

@trucy
Copy link

trucy commented Apr 8, 2023

Steps to reproduce for send list:

  1. Click Send from Balances tab
  2. Select token
  3. Enter username or address of someone you're not friends with on Backpack
  4. "Other people" section returns empty array/list instead of avatars and username matches

Send view:

  1. Click Send from Balances tab
  2. Select token
  3. Enter exact address of someone on Backpack
  4. On the next screen, only the wallet address shows up, when it should be their username
@wentokay
Copy link
Collaborator

wentokay commented Apr 8, 2023

I'll fix this as I think my PR introduced it, it's related to the api serving variations of snake_case and camelCase data

@wentokay wentokay assigned wentokay and unassigned hkirat Apr 8, 2023
@wentokay
Copy link
Collaborator

wentokay commented Apr 8, 2023

i.e. the api is currently returning public_keys.public_key but for the users to show it needs to be public_keys.publicKey

"public_keys": [{
	"blockchain": "solana",
-	"public_key": "aaa...aaa",
+	"publicKey": "aaa...aaa",
	"primary": true
}]

@trucy trucy added bug Something isn't working and removed priority 1 labels Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants