Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Interrogative sentences do not sound like questions #1099

Closed
Ca-ressemble-a-du-fake opened this issue Jan 13, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@Ca-ressemble-a-du-fake
Copy link

Hi and first of all thanks for this great project!

🐛 Description

I tried the Colab notebook "Zero-shot-TTS-Demo" in French and the results were stunning. But I could not hear a difference between "Vous en avez beaucoup!" and "Vous en avez beaucoup?" (note the ! vs ? at the end). I tried with other interrogative sentences and I could not hear a clear question being said.
So it does not seem that YourTTS handles question marks.

To Reproduce

Open YourTTS-Zero-shot-TTS-demo notebook in Colab. Run all the cells, upload around 60 seconds of target speaker wav files when prompted, change the "text" variable to "Vous en avez beaucoup? Vous en avez beaucoup! Vous en avez beaucoup.", launch the synthesis and hear the result. All thee sentences sound the same.

Expected behavior

Input text featuring a question mark should be said like a question.

Environment

{
"CUDA": {
"GPU": [],
"available": false,
"version": "10.2"
},
"Packages": {
"PyTorch_debug": false,
"PyTorch_version": "1.9.0+cu102",
"TTS": "0.2.0",
"numpy": "1.19.5"
},
"System": {
"OS": "Linux",
"architecture": [
"64bit",
""
],
"processor": "x86_64",
"python": "3.7.12",
"version": "#1 SMP Tue Dec 7 09:58:10 PST 2021"
}
}

Additional context

@Ca-ressemble-a-du-fake Ca-ressemble-a-du-fake added the bug Something isn't working label Jan 13, 2022
@Ca-ressemble-a-du-fake Ca-ressemble-a-du-fake changed the title [Bug] No difference between exclamatory and interrogative sentences [Bug] Interrogative sentences do not sound like questions Jan 13, 2022
@erogol
Copy link
Member

erogol commented Jan 14, 2022

Thanks for your feedback. It is not really a bug but I think it is important to handle such things properly. We'll consider your feedback for the next released model.

@Ca-ressemble-a-du-fake
Copy link
Author

@erogol Cool! Is there already a way to pronounce a question as it is supposed to sound ? Maybe you are telling this is not possible in this Colab notebook but if I fine tuned the model with a dataset featuring questions, would it work ?

@skol101
Copy link

skol101 commented Jan 14, 2022

Curious, if the model is provided enough interrogative samples , will it learn to proncounce text differently if it ends with a "?"

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Feb 13, 2022
@coqui-ai coqui-ai deleted a comment from stale bot Feb 14, 2022
@stale stale bot removed the wontfix This will not be worked on but feel free to help. label Feb 14, 2022
@erogol
Copy link
Member

erogol commented Feb 14, 2022

I close this as it does not really a bug but a feature request maybe. But we'll keep this in mind for the next release of the model.

@erogol erogol closed this as completed Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants