Fix: Addressing Vulnerability in Cloned Function #13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation in some cases does not finish for non-prime p. This fixes CVE-2022-0778. Based on patch by David Benjamin <davidben@google.com>. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org>
github-actions bot
pushed a commit
to zesming/lede
that referenced
this pull request
Feb 17, 2025
* https://github.com/coolsnowwolf/lede: mt7615d: fix possible infinite loop in BN_mod_sqrt() (coolsnowwolf#13346)
github-actions bot
added a commit
to EorFiey/Autobuild-LEDE
that referenced
this pull request
Feb 17, 2025
* https://github.com/coolsnowwolf/lede: generic: add more switch port link speed nested attributes mt7615d: fix possible infinite loop in BN_mod_sqrt() (coolsnowwolf#13346)
github-actions bot
added a commit
to BCYDTZ/lede
that referenced
this pull request
Feb 17, 2025
* https://github.com/coolsnowwolf/lede: generic: add more switch port link speed nested attributes mt7615d: fix possible infinite loop in BN_mod_sqrt() (coolsnowwolf#13346)
github-actions bot
pushed a commit
to evenwangcn/lede
that referenced
this pull request
Feb 17, 2025
* https://github.com/coolsnowwolf/lede: generic: add more switch port link speed nested attributes mt7615d: fix possible infinite loop in BN_mod_sqrt() (coolsnowwolf#13346)
github-actions bot
added a commit
to ZeaKyX/lede
that referenced
this pull request
Feb 18, 2025
* https://github.com/coolsnowwolf/lede: qualcommax: default to kernel 6.6 generic: add more switch port link speed nested attributes mt7615d: fix possible infinite loop in BN_mod_sqrt() (coolsnowwolf#13346)
|
Hey @coolsnowwolf, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a security vulnerability in BN_mod_sqrt() that was cloned from OpenSSL but did not receive the security patch applied in OpenSSL. The original issue was reported and fixed under CVE-2022-0778.
Issue Details
The function BN_mod_sqrt() in this repository is nearly identical to BN_mod_sqrt() from OpenSSL.
The original function was patched due to a vulnerability identified in CVE-2022-0778.
The same issue exists in this repository's function but remains unpatched.
Proposed Fix
This PR applies the same patch as the one in OpenSSL to eliminate the vulnerability.
References
CVE: CVE-2022-0778
Original Fix: Original Fix