Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfurl metadata not removed from a retracted message. #2852

Open
jcbrand opened this issue Mar 16, 2022 · 3 comments
Open

Unfurl metadata not removed from a retracted message. #2852

jcbrand opened this issue Mar 16, 2022 · 3 comments

Comments

@jcbrand
Copy link
Member

jcbrand commented Mar 16, 2022

Describe the bug

When retracting a message that contains unfurl metadata, the message body gets deleted, but not the metadata.

To Reproduce

Enter discuss@conference.conversejs.org (a MUC that supports unfurls), and send a message containing a link, e.g. a link to a Github issue.

Then retract that message. Recipients see that the message is retracted but they still see the image and other metadata from the Github issue.

Expected behavior
All message data should be removed.

Screenshots
Screenshot 2022-03-16 at 13 56 36

Environment (please complete the following information):

  • Converse.js version: master

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jcbrand
Copy link
Member Author

jcbrand commented Mar 23, 2022

The message template needs to be updated to now show metadata if the message has been retracted, see here:

${ el.model.get('ogp_metadata')?.map(m => {

We'll also need a test to confirm that it works.

@aakashkumarjee
Copy link

Hi @jcbrand, I am new here & interested in this Project. Can I contribute to this issue?

@jcbrand
Copy link
Member Author

jcbrand commented Apr 15, 2022

Hi @aakashkumarjee, definitely. Any contributions are appreciated. You're welcome to tackle this ticket, or take a look here:
#2481

If you have questions, you can ask them in our XMPP chatroom:
https://inverse.chat/#converse/room?jid=discuss@conference.conversejs.org

To join directly from an XMPP client: xmpp://discuss@conference.conversejs.org?join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants