Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip locked MUC domain from room address input #2311

Open
mwild1 opened this issue Oct 23, 2020 · 2 comments
Open

Strip locked MUC domain from room address input #2311

mwild1 opened this issue Oct 23, 2020 · 2 comments
Labels
bug good first issue MUC Related to multi-user chats (MUC) / group chats UX User experience

Comments

@mwild1
Copy link

mwild1 commented Oct 23, 2020

Is your feature request related to a problem? Please describe.

  1. Deploy a configuration that has a locked MUC domain, e.g. muc.example.org
  2. Click Add a new groupchat
  3. Enter a room address like room@muc.example.org
  4. The @ gets escaped and Converse.js attempts to join room\40muc.example.org@muc.example.org

Describe the solution you'd like

If the input ends with @<locked domain> then it should be stripped before further processing.

Rationale

If the entered address ends with @<locked domain> it is almost certainly not the user's intention to have the full input as the room name, but means the user entered the full address of a room.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@jcbrand
Copy link
Member

jcbrand commented Oct 23, 2020

@bernard-ng: Something you'd be willing to look into?

@bernard-ng
Copy link
Contributor

@bernard-ng: Something you'd be willing to look into?

Yes gladly

@Echolon Echolon added the MUC Related to multi-user chats (MUC) / group chats label Apr 2, 2021
@issuehunt-oss issuehunt-oss bot added 💵 Funded on Issuehunt This issue has been funded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Apr 30, 2022
@conversejs conversejs deleted a comment from issuehunt-oss bot Apr 30, 2022
@conversejs conversejs deleted a comment from issuehunt-oss bot Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue MUC Related to multi-user chats (MUC) / group chats UX User experience
Projects
None yet
Development

No branches or pull requests

4 participants