Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

writer not grouping by type when used with transform #18

Closed
fpereira1 opened this issue Jun 27, 2016 · 3 comments
Closed

writer not grouping by type when used with transform #18

fpereira1 opened this issue Jun 27, 2016 · 3 comments

Comments

@fpereira1
Copy link

fpereira1 commented Jun 27, 2016

Hi, great library guys.

I started using this library for my project. While all the commits appear as output, they are not being grouped by type, which is meant to be the default for the writer?

I am running this as: node changelog.js

var conventionalChangelogCore = require('conventional-changelog-core');

conventionalChangelogCore({
    transform : function(commit, cb) {

      if(/^FIX/.test(commit.header)) {
        commit.type = 'bug';
      }

      if(/^NEW|FEATURE/.test(commit.header)) {
        commit.type = 'feat';
      }

      if(/^bump version --skip-ci/.test(commit.header)) {
        commit = null;
      }

      cb(null, commit);
    },
  })
  .pipe(process.stdout); // or any writable stream

@stevemao
Copy link
Collaborator

You might want to have a look at conventional-changelog-archived-repos/conventional-changelog-writer#20

@stevemao
Copy link
Collaborator

did you try to config this properly? the writer api will be changed soon.

@hutson
Copy link
Contributor

hutson commented Feb 5, 2018

We're closing this issue out as this repository has been merged into our conventional-changelog mono-repository.

If you would like to see this change incorporated into conventional-changelog please consider re-opening the issue against the conventional-changelog mono-repository.

@hutson hutson closed this as completed Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants