Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialMenuButton Menu Sizing #36

Closed
eceowl opened this issue Dec 19, 2018 · 3 comments
Closed

MaterialMenuButton Menu Sizing #36

eceowl opened this issue Dec 19, 2018 · 3 comments
Labels
bug Something isn't working valid This issue/bug/feature request is valid

Comments

@eceowl
Copy link

eceowl commented Dec 19, 2018

Describe the bug
On Android, the menu of the MaterialMenuButton appears to calculate it's width based on the length of the last choice in the choice list. If choices before the last choice are longer, it truncates them.

To Reproduce
Steps to reproduce the behavior:
Create a MaterialMenuButton with multiple choices where the length of the last string is shorter than the length of the other choices.

Expected behavior
All choices should fit in the menu regardless of the order in which they are placed.

Screenshots
screenshot_20181219-142135
screenshot_20181219-142301

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S9+
@eceowl
Copy link
Author

eceowl commented Dec 19, 2018

Update: On iOS it cuts off too but even if I put the longest at the bottom

@contrix09
Copy link

Will look into this.

@contrix09 contrix09 self-assigned this Jan 1, 2019
@contrix09 contrix09 added the bug Something isn't working label Jan 1, 2019
@contrix09 contrix09 added the valid This issue/bug/feature request is valid label Jan 7, 2019
@contrix09
Copy link

Hi, this issue has been fixed. Will release the new version later. Keep in mind that the menu has a maximum width of 280, and a minimum width of 112.

@contrix09 contrix09 removed their assignment Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working valid This issue/bug/feature request is valid
Projects
None yet
Development

No branches or pull requests

1 participant