Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Android Build Chain #70

Open
bcortens opened this issue Mar 15, 2023 · 4 comments
Open

Incompatible with Android Build Chain #70

bcortens opened this issue Mar 15, 2023 · 4 comments

Comments

@bcortens
Copy link

bcortens commented Mar 15, 2023

Currently because of the Catch2 and fmt dependencies it is incompatible with android - these two packages are not being correctly fetched and built when using the android grande build system.

Adding libunicode to an AndroidStudio CMakeLists file does not currently work correctly.

Error:
Could not find a package configuration file provided by "fmt" with any of
the following names:
fmtConfig.cmake
fmt-config.cmake

Could not find a package configuration file provided by "Catch2" with any
of the following names:
Catch2Config.cmake
catch2-config.cmake

@christianparpart
Copy link
Member

Hey, many thanks for your interest.

Oh wow. I don't do Android stuff. I am not sure (out of my head) how to fix this but I will try looking into it .

The only important one as a user is DMT anyways. But if you don't need that, we could make that optional. Would that suffice?

@bcortens
Copy link
Author

bcortens commented Mar 15, 2023

Hello,
Yes I actually was able to set testing to false and then comment out the Catch2 dependencies and that solved that part of the problem (though obviously commenting out the code is not a long term solution).

I am currently making modifications to my version to remove the FMT formatting of the statements for now. Again not a long term solution but I am just trying to get it working for now.

EDIT: FMT is pretty deeply integrated in the ucd_fmt and looks like it might be more work than just removing the print statements.

@christianparpart
Copy link
Member

@bcortens did you actually try running the https://github.com/contour-terminal/libunicode/blob/master/scripts/install-deps.sh script? That should have been providing the necessary dependencies.

I have no experience with AndroidStudio yet, would you mind telling me what OS you've been using when using it? I'd like to give the setup a try. :)

@Yaraslaut
Copy link
Member

Yaraslaut commented Jul 25, 2023

Hello, Yes I actually was able to set testing to false and then comment out the Catch2 dependencies and that solved that part of the problem (though obviously commenting out the code is not a long term solution).

I am currently making modifications to my version to remove the FMT formatting of the statements for now. Again not a long term solution but I am just trying to get it working for now.

EDIT: FMT is pretty deeply integrated in the ucd_fmt and looks like it might be more work than just removing the print statements.

Any update on situation? Catch2 dependency is made optional here #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants