Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect user from accidentally pasting too large input #1198

Closed
2 tasks
christianparpart opened this issue Sep 11, 2023 · 1 comment · Fixed by #1643
Closed
2 tasks

Protect user from accidentally pasting too large input #1198

christianparpart opened this issue Sep 11, 2023 · 1 comment · Fixed by #1643
Assignees
Labels
enhancement New feature or request frontend Contour Terminal Emulator (GUI frontend)
Milestone

Comments

@christianparpart
Copy link
Member

@Marenz just found out, that when pasting too big text data to Contour, it will freeze (or at least looks like this).

After a short investigation, we found out that the data to be pasted was still being pasted, it just takes very long. Most likely because the way we do it is certainly not most efficient.

Action items

  • Ask the user something like: "Are you sure you want to paste {X amount} characters?" in a Yes/No dialog and only continue pasting on Yes, abort otherwise.
  • If the content is really to be pasted, make sure it's more efficiently done and NOT blocking the GUI thread
@christianparpart christianparpart added enhancement New feature or request frontend Contour Terminal Emulator (GUI frontend) labels Sep 11, 2023
@Yaraslaut
Copy link
Member

Yaraslaut commented Apr 25, 2024

I noticed that BracketedPaste decmode breaks rendering while pasting more than one screen of text and is enabled by default, so if i for example start with

echo "
> 

I can not paste large text. I am not sure what to do with this, maybe @christianparpart or @j4james you can help out with what is the right solution for this one

@Yaraslaut Yaraslaut added this to the 2024-1 milestone Oct 22, 2024
@Yaraslaut Yaraslaut self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants