feat: sort entries by references before add #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcolink
approved these changes
Aug 12, 2024
screamcha
requested changes
Aug 13, 2024
There was a problem hiding this comment.
In general I prefer using native JS methods, especially if it's straightforward, because of the following reasons:
- it improves code readability - it's safer to assume that more people are familiar with native JS methods than methods from 3rd party lib
- it reduces dependency on the 3rd party lib
- in most of the cases it doesn't bring any value as the language provides decent alternatives
I'd ask you to refrain from such methods asmap,filter,getetc. from lodash where they don't bring more to the table compared to the native methods.
I will be happy to discuss it further, there's a high chance I'm missing something so feel free to let me know :)
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid errors when creating entries using the contentful-merge cli, we introduced a sort on the Add task where we make sure we order the Add changeset in a way that the referenced entries come before the entries they are referenced in.