Fix access log field parsing #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
added
status/2-needs-review
kind/bug/fix
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
traefiker
force-pushed
the
GH-3841-fix-access-log-field-parsing
branch
from
47ddbf7 to
fba516f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes #3841 and adds a unit test to cover the specific case that was causing it.
Basically, when using a YAML file to pass arguments, they are passed with escaped backquotes if backquotes are present in the input YAML file.
For example:
Would be received by the flaeg parser as
"Username=drop Hostname=drop ClientUsername=drop ClientHost=drop". The parser then used to break it down into key value pairs and store it in a map. What happened was that for the last key (hereClientHostin this example, the value had a backquote at the end of it (drop"in this case), which didn't match with eitherdrop,keeporredact. It was then replaced by the default value.Removing the backquotes in the YAML file was a workaround for this, but it definitely isn't intuitive, so a fix was needed in the parser itself to handle that case.
No documentation change should be needed.
Motivation
Fixing #3841
More