Correctly initialize kv store if storage key missing #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
kind/bug/fix
It looks like this commit might have introduced a bug (I'm new to the code, so I might be wrong): e4bb506#diff-89592b0a96bd24ccd41291548f9a07a3 On line 88, keyExists will return an error ErrKeyNotFound if the key does not exists, because keyExists seems to not check if a key exists, but if a key is empty.
|
Great, thanks for the quick review and merge! What is the usual timeframe between path review (like 1.7.2 which will have the fix)? Going to use the containous/traefik image in the meantime to continue my tests. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It looks like this commit might have introduced a bug
(I'm new to the code, so I might be wrong):
e4bb506#diff-89592b0a96bd24ccd41291548f9a07a3
On line 88, keyExists will return an error ErrKeyNotFound if the key does not exists,
because keyExists seems to not check if a key exists, but if a key is empty.
Motivation
More
Additional Notes