Add a k8s guide section on traffic splitting via service weights. #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
kind/enhancement
yue9944882
reviewed
Jul 3, 2018
docs/user-guide/kubernetes.md
Outdated
|
|
||
| - The associated service backends must share the same path and host. | ||
| - The total percentage shared across all service backends must yield 100% (see the section on [omitting the final service](#omitting-the-final-service), however). | ||
| - The percentage values are interpreted as floating point numbers to a supported precision as defined in the [configuration details](/configuration/backends/kubernetes). |
There was a problem hiding this comment.
Could we add an anchor of this document? It's a long document and I don't think users might find the detail of this annotation easily.
/configuration/backends/kubernetes#specify-weight
There was a problem hiding this comment.
A deep link seems tricky to do unless we resort to using custom HTML in markdown. For now, I decided to point to the annotations section. Let me know what you think.
|
Pushed another commit that removes the canary use case example from the backend docs as we now have that in the user guide. I replaced it with a link. |
ldez
force-pushed
the
kubernetes/describe-service-weights-in-guide
branch
from
09deb4f to
45fe392
Compare
traefiker
force-pushed
the
kubernetes/describe-service-weights-in-guide
branch
from
45fe392 to
e55d75c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Explain service weights in the Kubernetes guide.
Motivation
To ease adoption of the feature for users.
Additional Notes
Complements #3112.
@dtomcej PTAL
/cc @yue9944882