cni: Fix bug while updating endpoints after scanning net namespace

After scanning the network namespace, we need to update the scanned
endpoints with the DNS information, and use the scanned endpoints
thereafter discarding the endpoints structures we had created prior
to calling into the CNI plugin.

There was a bug in the update, which was causing the entire endpoint
structure being assigned back to the scanned endpoints causing us to
lose information from the scan including if a virtual or physical
endpoint was found in the scan.

Signed-off-by: Archana Shinde <archana.m.shinde@intel.com>

cni.go

@@ -123,16 +123,15 @@ func (n *cni) updateEndpointsFromScan(networkNS *NetworkNamespace) error {
 		return err
 	}
 
-	for idx, endpoint := range endpoints {
+	for _, endpoint := range endpoints {
 		for _, ep := range networkNS.Endpoints {
 			if ep.Name() == endpoint.Name() {
 				// Update endpoint properties with info from
 				// the scan. Do not update DNS since the scan
 				// cannot provide it.
 				prop := endpoint.Properties()
 				prop.DNS = ep.Properties().DNS
-				ep.SetProperties(prop)
-				endpoints[idx] = ep
+				endpoint.SetProperties(prop)
 				break
 			}
 		}