Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quadlet kube should use logging #16592

Closed
alexlarsson opened this issue Nov 23, 2022 · 3 comments · Fixed by #16947
Closed

quadlet kube should use logging #16592

alexlarsson opened this issue Nov 23, 2022 · 3 comments · Fixed by #16947
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@alexlarsson
Copy link
Contributor

quadlet uses --log-driver passthrough for regular .container files. This means just forwarding the journal socket to the container as-is. This has the advantage that journald can see who the actual sender of the log event is, rather than thinking everything comes from the conmon process. It also means conmon doesn't have to copy all the log data.

I think we should do the same for .kube files, and thankfully the kube play already has a commandline option for this.

@vrothberg
Copy link
Member

@alexlarsson I think we can exploit the --service-container flag a bit. It's an internal flag and hidden from the CLI, and only used in the context of running in systemd.

Hence, such defaults can be set automatically with --service-container. For sure, it doesn't hurt to set them explicitly.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@ygalblum
Copy link
Contributor

Working on this issue. While the change is simple, since setting the log-driver to passthrough is not allowed on TTY, this change breaks the test for --service-container.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants