From 145c7511aa8d96db6d641aad3dc7603ca54d588c Mon Sep 17 00:00:00 2001 From: Ed Santiago Date: Mon, 19 Aug 2024 05:06:57 -0600 Subject: [PATCH] CI: disable ginkgo flake retries As discussed in Aug 13 Cabal, we are almost at a point where e2e tests are reliably passing on the first try. Let's try to keep things that way, and not hide future flakes. Closes: #17967 Signed-off-by: Ed Santiago --- Makefile | 2 +- test/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index bf61d5b6f85e..33d3f614259f 100644 --- a/Makefile +++ b/Makefile @@ -140,7 +140,7 @@ GINKGO ?= ./test/tools/build/ginkgo GINKGO_JSON ?= $(if $(CI),--json-report ginkgo-e2e.json,) # Allow control over some Ginkgo parameters -GINKGO_FLAKE_ATTEMPTS ?= 3 +GINKGO_FLAKE_ATTEMPTS ?= 0 GINKGO_NO_COLOR ?= y # Conditional required to produce empty-output if binary not built yet. diff --git a/test/README.md b/test/README.md index f374d3e7fbf2..6e67bb1a2600 100644 --- a/test/README.md +++ b/test/README.md @@ -130,7 +130,7 @@ make localintegration FOCUS="podman inspect bogus pod" You can control some of the parameters passed to Ginkgo - Disable parallel tests by setting `GINKGO_PARALLEL=n` -- Set flake retry count (default 3) to one by setting `GINKGO_FLAKE_ATTEMPTS=1` +- Set flake retry count (default 0) to one by setting `GINKGO_FLAKE_ATTEMPTS=1` - Produce colorful tests report by setting `GINKGO_NO_COLOR=n` # System tests