-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowing extension to provide routeId to progress task #8902
feat: allowing extension to provide routeId to progress task #8902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Works nicely!
} | ||
|
||
return { | ||
name: 'View', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still believe View details
or Inspect
is more accurate but as it's not part of the spec (.d.ts file), it can be easily changed over time (or not) later.
can merge and discuss it during UX discussions
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
28a3efd
to
a49317e
Compare
What does this PR do?
Allow extensions to provide a
navigation
object when usingwindow.withProgress
.Screenshot / video of UI
extension-custom-rout.mp4
What issues does this PR fix or reference?
Fixes #7709
How to test this PR?
Testing manually
Inside the activate of an extension add the following
and add the following to the extension package.json