feat(extension-api): allow extension to register custom navigation route #8837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel7083
requested review from
feloy,
deboer-tim and
gastoner
and removed request for
a team
benoitf
reviewed
Sep 11, 2024
benoitf
reviewed
Sep 11, 2024
benoitf
reviewed
Sep 12, 2024
feloy
reviewed
Sep 13, 2024
axel7083
force-pushed
the
feature/navigation-route-registry
branch
from
64e47dc
to
e0d5526
Compare
benoitf
approved these changes
Sep 13, 2024
benoitf
reviewed
Sep 13, 2024
benoitf
reviewed
Sep 13, 2024
benoitf
approved these changes
Sep 13, 2024
feloy
approved these changes
Sep 16, 2024
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Co-authored-by: Philippe Martin <feloy1@gmail.com> Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
force-pushed
the
feature/navigation-route-registry
branch
from
8f59469
to
81db0f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following a discussion we had with @benoitf about #7709. The idea would be to make the extension register a unique navigation route id.
When they create a notification or a task, they could register the navigation route id with some arguments, so the core could navigate to the appropriate route.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Required for #7709
How to test this PR?