fix: prevent registered route from being overwritten

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
containers · Sep 13, 2024 · 06611cb · 06611cb
1 parent e0d5526
commit 06611cb
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/packages/main/src/plugin/navigation/navigation-manager.spec.ts b/packages/main/src/plugin/navigation/navigation-manager.spec.ts
@@ -185,6 +185,21 @@ describe('register route', () => {
     expect(navigationManager.hasRoute(routeId)).toBeFalsy();
   });
 
+  test('registering existing route should throw an error', async () => {
+    const routeId = 'dummy-route-id';
+    navigationManager.registerRoute({
+      routeId: routeId,
+      commandId: 'fake-command-id',
+    });
+
+    expect(() => {
+      return navigationManager.registerRoute({
+        routeId: routeId,
+        commandId: 'fake-command-id',
+      });
+    }).toThrowError('routeId dummy-route-id is already registered.');
+  });
+
   test('calling navigateToRoute with invalid routeId should raise an error', async () => {
     await expect(() => {
       return navigationManager.navigateToRoute('invalidId');

diff --git a/packages/main/src/plugin/navigation/navigation-manager.ts b/packages/main/src/plugin/navigation/navigation-manager.ts
@@ -53,6 +53,9 @@ export class NavigationManager {
   }
 
   registerRoute(route: NavigationRoute): Disposable {
+    if (this.hasRoute(route.routeId)) {
+      throw new Error(`routeId ${route.routeId} is already registered.`);
+    }
     this.#registry.set(route.routeId, route);
 
     return Disposable.create(() => {