Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support task redirection #1745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

axel7083
Copy link
Contributor

What does this PR do?

Adding the support of tasks action (navigation) in AI Lab

Screenshot / video of UI

Screencast.from.2024-09-18.17-34-25.mp4

What issues does this PR fix or reference?

Fixes #1742

⚠️ Creating an inference server do not create a task (need to create an issue)

How to test this PR?

  • unit tests has been added ✔️
  1. start AI Lab
  2. Go to recipe
  3. Start a recipe
  4. Leave AI Lab
  5. Open Task Manager
  6. Click on View for the recipe pulling task

@gastoner
Copy link

Screen.Recording.2024-09-19.072843.mp4

When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

@axel7083
Copy link
Contributor Author

When downloading multiple models, each for a different recipe, it will show only the first "tasks model" clicked.

Oh, I see, we can see the task page is updated, but apparently the model in the Select is not updated.

image

image

I will take a look, nice catch

@benoitf
Copy link
Collaborator

benoitf commented Sep 25, 2024

converting to draft for now, as I always see a reminder that I need to review this PR and then open it and then say "ah yes we're missing another fix first"

Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
@axel7083
Copy link
Contributor Author

@gastoner the problem reported is fixed!

@axel7083 axel7083 marked this pull request as ready for review September 27, 2024 12:06
@gastoner
Copy link

Redirection to task works well, just I think that the issue is still present

Screen.Recording.2024-09-27.150126.mp4

I think I have current version
image

@axel7083
Copy link
Contributor Author

axel7083 commented Sep 27, 2024

I think I have current version

Did you rebuild the extension ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI Lab Tasks should use Podman Desktop navigation route
3 participants