-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Mistral Instruct model to the catalog #1773
base: main
Are you sure you want to change the base?
Conversation
Fixes containers#1771 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@@ -303,6 +303,19 @@ | |||
}, | |||
"sha256": "893ae2442b36b2e8e1134ccbf8c0d9bd670648d0964509202ab30c9cbb3d2114", | |||
"backend": "none" | |||
}, | |||
{ | |||
"id": "hf.MaziyarPanahi.Mistral-7B-Instruct-v0.3.Q4_K_M", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it come from https://huggingface.co/mistralai rather than "hf.MaziyarPanahi"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't provide GGUF files thus this repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we have a process to say if we include or not a model like if we can trust the author or not, if there are no changes from the original model etc but it's a different story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I know we had some idea at some point to include the model converter (.safetensor => gguf) inside ai lab
- Integrate Model converter for running models without GGUF file #542
- https://github.com/containers/ai-lab-recipes/tree/main/convert_models
Maybe we should re-evaluate this ?
That needs to be tested first as GGUF contains model metadata (template,...) that are not present in the safe tensor format |
Fixes #1771
What does this PR do?
Add a new model to the catalog
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#1771
How to test this PR?
Test with playground