Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topology-aware: don't ignore HBM memory nodes without close CPUs. #329

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

klihub
Copy link
Collaborator

@klihub klihub commented Jun 11, 2024

Treat HBM memory nodes without close CPUs similarly to PMEM nodes, IOW assign them to the closest DRAM node as extra capacity. Also, for now don't ever allocate HBM memory implicitly to containers.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from askervin June 11, 2024 11:37
Handle HBM memory nodes without close CPUs identically to PMEM
nodes. That is, assign memory from such a node to the closest
DRAM node as extra memory.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Don't assign HBM memory implicitly for containers not asking
for any particular memory type. Ideally we either should make
this configurable, or teach the memory allocator to fall back
using special memory if the allocation would otherwise fail.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub force-pushed the fixes/topology-aware-hbm-allocation branch from 07e24a0 to 64dca5e Compare June 11, 2024 11:40
Copy link
Collaborator

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @klihub, this is very nice.

@klihub klihub marked this pull request as ready for review June 18, 2024 07:17
@askervin askervin merged commit b9649e5 into containers:main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants