Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase CONFIG_NR_CPUS #74

Closed
asahilina opened this issue Nov 4, 2024 · 2 comments · Fixed by #75
Closed

Increase CONFIG_NR_CPUS #74

asahilina opened this issue Nov 4, 2024 · 2 comments · Fixed by #75

Comments

@asahilina
Copy link
Contributor

asahilina commented Nov 4, 2024

In muvm we use the pcore count as the CPU count. On M1/M2 Max that's already 8, and on the Ultra variants it becomes 16. Meanwhile M3 and M4 Max have up to 12 pcores, and the hypothetical Ultra variants 24. M4 Pro also has 10 pcores.

So CONFIG_NR_CPUS=8 is insufficient for 5 different chips already on the market (2 of which Asahi Linux already supports). We need at least 16, but most likely 24 for the almost-certain-to-come M4 Ultra. If the rumored quad chip monster device finally materializes, then we'd need up to 48.

@slp
Copy link
Contributor

slp commented Nov 4, 2024

We always knew this need would arise sooner than later. Since we can easily produce new libkrunfw releases, I'd like to play it conservative and bump it first to 16, and then bump it further when the new chips hit the market. WDYT?

@asahilina
Copy link
Contributor Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants