Skip to content

Commit 44ef3a8

Browse files
Merge pull request #5580 from dfr/freebsd-resolv-conf
buildah: fix a nil pointer reference on FreeBSD
2 parents a7bc7b5 + 1480f14 commit 44ef3a8

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

run_common.go

+7-2
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,17 @@ func (b *Builder) createResolvConf(rdir string, chownOpts *idtools.IDPair) (stri
8484

8585
// addResolvConf copies files from host and sets them up to bind mount into container
8686
func (b *Builder) addResolvConfEntries(file string, networkNameServer []string,
87-
namespaces []specs.LinuxNamespace, keepHostServers, ipv6 bool) error {
87+
spec *specs.Spec, keepHostServers, ipv6 bool) error {
8888
defaultConfig, err := config.Default()
8989
if err != nil {
9090
return fmt.Errorf("failed to get config: %w", err)
9191
}
9292

93+
var namespaces []specs.LinuxNamespace
94+
if spec.Linux != nil {
95+
namespaces = spec.Linux.Namespaces
96+
}
97+
9398
dnsServers, dnsSearch, dnsOptions := b.CommonBuildOpts.DNSServers, b.CommonBuildOpts.DNSSearch, b.CommonBuildOpts.DNSOptions
9499
nameservers := make([]string, 0, len(defaultConfig.Containers.DNSServers.Get())+len(dnsServers))
95100
nameservers = append(nameservers, defaultConfig.Containers.DNSServers.Get()...)
@@ -1254,7 +1259,7 @@ func (b *Builder) runUsingRuntimeSubproc(isolation define.Isolation, options Run
12541259
}
12551260

12561261
if resolvFile != "" {
1257-
err = b.addResolvConfEntries(resolvFile, netResult.dnsServers, spec.Linux.Namespaces, netResult.keepHostResolvers, netResult.ipv6)
1262+
err = b.addResolvConfEntries(resolvFile, netResult.dnsServers, spec, netResult.keepHostResolvers, netResult.ipv6)
12581263
if err != nil {
12591264
return err
12601265
}

run_linux.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ func (b *Builder) Run(command []string, options RunOptions) error {
423423
// Only add entries here if we do not have to do setup network,
424424
// if we do we have to do it much later after the network setup.
425425
if !configureNetwork {
426-
err = b.addResolvConfEntries(resolvFile, nil, spec.Linux.Namespaces, false, true)
426+
err = b.addResolvConfEntries(resolvFile, nil, spec, false, true)
427427
if err != nil {
428428
return err
429429
}

0 commit comments

Comments
 (0)