Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bridge:get dns config from /etc/cni/net.d default config, not from ipam plugins #431

Closed
jamin-hon opened this issue Dec 23, 2019 · 1 comment · Fixed by #733
Closed

bridge:get dns config from /etc/cni/net.d default config, not from ipam plugins #431

jamin-hon opened this issue Dec 23, 2019 · 1 comment · Fixed by #733

Comments

@jamin-hon
Copy link

Referring to ducuments, bridge plugins does not contain dns config which ipam host-local and static plugins does.
But i found that bridge get dns config from /etc/cni/net.d original config, not from ipam plugins by reading and testing the source code.

@davdiv
Copy link

davdiv commented Jan 13, 2021

Indeed, I came across the same issue:

result.DNS = n.DNS

The DNS in the result is copied from n, which is the bridge configuration (and nothing is mentioned in the following page regarding the possibility to pass a dns field: https://www.cni.dev/plugins/main/bridge/).
It should be copied from ipamResult.DNS, according to the documentation (https://www.cni.dev/plugins/ipam/host-local/). As a result, resolvConf in host-local configuration is mistakenly ignored when used with bridge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants