sync-server: Fix infinite loop caused by accept error #271
Conversation
src/sync/server.rs
Outdated
| @@ -373,6 +374,9 @@ impl Server { | |||
| } | |||
| Err(e) => { | |||
| error!("listener accept got {:?}", e); | |||
| // Since poll is level-triggered, an uncorrected error can lead to an infinite loop, | |||
| // so we sleep for a while and wait for the error to be corrected. | |||
| thread::sleep(Duration::from_secs(10)); | |||
There was a problem hiding this comment.
10 seconds seem like a long time?
There was a problem hiding this comment.
Yes, It's a long time for a program, but the errors of accept such as EMFILE and ENOMEM can't be recovered in a short time.
There was a problem hiding this comment.
I think I could add a method server.set_accept_retry_interval, so users can customize the sleep duration
There was a problem hiding this comment.
Hi, @jsturtevant I have added the method set_accept_retry_interval.
There was a problem hiding this comment.
Thanks for making it configurable.
If it wasn't resolved in 10s wouldn't the continue loop still get stuck? In either case, would EMFILE is eventually resolved, wouldn't the loop finish?
Is the sleep to resolve cpu cycles while those errors occur? Should this only be done for a subclass of errors? seems like if there was a transient error we would slow things down significantlly.
Tim-Zhang
force-pushed
the
fix-infinite-accept-loop-master
branch
from
8085622 to
a845820
Compare
Also Add the method set_accept_retry_interval. Since poll is level-triggered, an uncorrected error can lead to an infinite loop, so we sleep for a while and wait for the error to be corrected. Fixes: containerd#270 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
force-pushed
the
fix-infinite-accept-loop-master
branch
from
a845820 to
47f828a
Compare
Since poll is level-triggered, an uncorrected error can lead to an infinite loop, so we sleep for a while and wait for the error to be corrected.
Fixes: #270