Add a dangling image prefix when tag name is not specified. #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
force-pushed
the
noneimage
branch
3 times, most recently
from
fd0e942
to
f1a4107
Compare
|
@AkihiroSuda can I get a review on this please. |
fahedouch
reviewed
Oct 27, 2022
|
@manugupt1 Doesn't moby/buildkit#3212 affect this implementation? |
It affects only scratch images or images with no layer. moby/buildkit#3212 (comment) ; unpacking should be skipped for when there are no layers I believe is the right solution in buildkit. Also, this bug comes only when images are built with no tag and has no layers. There is a bug, however, when buildkit fixes that bug; we won't have to fix it on our end with this change later.
|
manugupt1
force-pushed
the
noneimage
branch
4 times, most recently
from
c24eeb1
to
6f81b76
Compare
|
@ktock PTAL, this and the PR (moby/buildkit#3251) in buildkit should fix all the concerns so far. LMK if you have questions. |
AkihiroSuda
reviewed
Nov 3, 2022
cmd/nerdctl/build_test.go
Outdated
|
|
||
| func TestBuildNoTag(t *testing.T) { | ||
| testutil.RequiresBuild(t) | ||
| testutil.DockerIncompatible(t) |
Fixes: containerd#1398 Signed-off-by: Manu Gupta <manugupt1@gmail.com>
manugupt1
requested review from
AkihiroSuda
and removed request for
fahedouch
ktock
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1398