Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Planned on Nov 4, 2022] switch to main as default branch #1444

Closed
fahedouch opened this issue Oct 17, 2022 · 8 comments
Closed

[Planned on Nov 4, 2022] switch to main as default branch #1444

fahedouch opened this issue Oct 17, 2022 · 8 comments

Comments

@fahedouch
Copy link
Member

fahedouch commented Oct 17, 2022

What is the problem you're trying to solve

Hello,

Most of nerdctl related project(s) default branches have been changed to main eg..: containerd core project. So it is confusing to work with master branch

Describe the solution you'd like

rename default branch to main

Additional context

Why renaming to main ? https://github.com/github/renaming#why-main
take consideration of this points: https://github.com/github/renaming#whats-already-changed

@fahedouch fahedouch changed the title swtich to main as default branch switch to main as default branch Oct 17, 2022
@Zheaoli
Copy link
Member

Zheaoli commented Oct 17, 2022

SGTM

@junnplus
Copy link
Member

LGTM

@AkihiroSuda
Copy link
Member

SGTM, but can we have a couple of weeks as a grace period?

@fahedouch
Copy link
Member Author

SGTM, but can we have a couple of weeks as a grace period?

For sure.

@AkihiroSuda
Copy link
Member

Let's do this two weeks later (Nov 4)

@AkihiroSuda AkihiroSuda changed the title switch to main as default branch [Planned on Nov 4, 2022] switch to main as default branch Oct 21, 2022
@fahedouch
Copy link
Member Author

Let's do this two weeks later (Nov 4)

@AkihiroSuda Why are you postponing the switch ? shall I start working on this (switch content reference to main) or I have to wait for (Nov 4)

@AkihiroSuda
Copy link
Member

To minimize possibility of breaking somebody's environments, let's have two weeks of grace period

@AkihiroSuda
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants