-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support SOCI snapshotter #1329
Comments
I'm interested about this feature, maybe I can make a try( |
@Zheaoli I'd like to work on this if you haven't started :) |
Sorry about this,I have worked on it already :) |
np :) let me know if you need a review when the PR is out and I'd like to learn more about it |
@AkihiroSuda Do you think we can just package SOCI in nerdctl-full at the same time of supporting soci pull and run? SOCI is around 20MB now. https://github.com/awslabs/soci-snapshotter/releases |
@AkihiroSuda Hi, I'm working on #2347 to support soci in pull and run. I'm also wondering if SOCI could be packaged in nerdctl-full. |
I fear that we will end up including every third party snapshotter in the nerdctl-full bundle, so I'm not inclined to do that. This is still negotiable, but if we are going to including SOCI (and other snapshotters) in the |
@AkihiroSuda Sounds good. For the current change, we will just exclude SOCI from nerdctl distribution. I think other dependencies like Cosign, Notation are in the same situation. In the future, we can potentially include them in Letting downstream manage the dependencies by themselves is also not bad. (Package their own nerdctl tar and overwrite in Lima local archive) This can offload the logic of nerdctl distribution. |
@AkihiroSuda Should we resolve the issue? |
https://github.com/awslabs/soci-snapshotter
The text was updated successfully, but these errors were encountered: