Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SOCI snapshotter #1329

Closed
AkihiroSuda opened this issue Aug 20, 2022 · 9 comments
Closed

Support SOCI snapshotter #1329

AkihiroSuda opened this issue Aug 20, 2022 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@AkihiroSuda
Copy link
Member

https://github.com/awslabs/soci-snapshotter

@AkihiroSuda AkihiroSuda added enhancement New feature or request help wanted Extra attention is needed labels Aug 20, 2022
@Zheaoli
Copy link
Member

Zheaoli commented Aug 20, 2022

I'm interested about this feature, maybe I can make a try(

@djdongjin
Copy link
Member

@Zheaoli I'd like to work on this if you haven't started :)

@Zheaoli
Copy link
Member

Zheaoli commented Nov 18, 2022

@Zheaoli I'd like to work on this if you haven't started :)

Sorry about this,I have worked on it already :)

@djdongjin
Copy link
Member

np :) let me know if you need a review when the PR is out and I'd like to learn more about it

@ningziwen
Copy link
Contributor

@AkihiroSuda Do you think we can just package SOCI in nerdctl-full at the same time of supporting soci pull and run? SOCI is around 20MB now. https://github.com/awslabs/soci-snapshotter/releases

@CodeChanning
Copy link
Contributor

@AkihiroSuda Hi, I'm working on #2347 to support soci in pull and run. I'm also wondering if SOCI could be packaged in nerdctl-full.

@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Jul 19, 2023

@AkihiroSuda Do you think we can just package SOCI in nerdctl-full at the same time of supporting soci pull and run? SOCI is around 20MB now. https://github.com/awslabs/soci-snapshotter/releases

I fear that we will end up including every third party snapshotter in the nerdctl-full bundle, so I'm not inclined to do that.

This is still negotiable, but if we are going to including SOCI (and other snapshotters) in the nerdctl-full bundle, probably we should rename the current nerdctl-full to something like nerdctl-large.
Lima will use nerdctl-large (w/o SOCI) by default, but Finch may use the new nerdctl-full (w/ SOCI) by default.

@ningziwen
Copy link
Contributor

ningziwen commented Jul 23, 2023

@AkihiroSuda Sounds good. For the current change, we will just exclude SOCI from nerdctl distribution.

I think other dependencies like Cosign, Notation are in the same situation.

In the future, we can potentially include them in nerdctl-full and keep current one as nerdctl-large or nerdctl-core.

Letting downstream manage the dependencies by themselves is also not bad. (Package their own nerdctl tar and overwrite in Lima local archive) This can offload the logic of nerdctl distribution.

@ningziwen
Copy link
Contributor

@AkihiroSuda Should we resolve the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants