Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

cri path issue #1279

Closed
kfox1111 opened this issue Sep 19, 2019 · 2 comments · Fixed by #1280
Closed

cri path issue #1279

kfox1111 opened this issue Sep 19, 2019 · 2 comments · Fixed by #1280
Assignees
Milestone

Comments

@kfox1111
Copy link

Using containerd 1.2.8 or 1.2.9, containers fail to search the path if env PATH is not defined inside the container.

Simple reproducer

apiVersion: v1
kind: Pod
metadata:
  name: test
spec:
  containers:
  - command:
    - sh
    - -cxe
    - |
      while true; do
        sleep 1000;
      done
    image: docker.io/gitlab/gitlab-runner-helper:x86_64-latest
    imagePullPolicy: Always
    name: main

Much more detail in containerd/containerd#3597

Containers fail like so:
"ad62ed990987fba56502eb63d63b00a4804f2b0c77feb1a2f8b92cd3bb98b1be": OCI runtime exec failed: exec failed: container_linux.go:345: starting container process caused "exec: "sh": executable file not found in $PATH": unknown

@estesp estesp transferred this issue from containerd/containerd Sep 19, 2019
@estesp estesp self-assigned this Sep 19, 2019
@estesp
Copy link
Member

estesp commented Sep 19, 2019

{ note I've moved this to the CRI as the PR to fix the issue is in this repository }
@kfox1111 disappointing that we missed the alternate path to creating an OCI spec in the CRI implementation that lost the default $PATH due to the changes in containerd. PR #1280 will fix this and then we can figure out a path to get the 1.2.x release line fixed.

@Random-Liu
Copy link
Member

Random-Liu commented Sep 19, 2019

This is bad... I can imagine how this will break people after upgrade.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants